KoPKB/kaunter
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

Merge pull request 'DONE: use constant for min and max pinjaman' (#21) from bugfix/limit-error-cara-terima into main

Browse Source 
Reviewed-on: #21
This commit was merged in pull request #21.
This commit is contained in:
ismailmasseran
2026-09-20 16:28:38 +08:00
parent 918502b504 8e19d0488a
commit 1d71a31078
2 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/GadaianController.php
+5 -2
View File
@@ -22,6 +22,9 @@ use Illuminate\Support\Facades\Log;
class GadaianController extends Controller
{
const MIN_PINJAMAN = 5.00;
const MAX_PINJAMAN = 50000.00;
public $AliranTunaiController;
public $customerService;
@@ -242,8 +245,8 @@ class GadaianController extends Controller
$caraTerima = strtoupper((string) $request->input('cara_terima', 'TUNAI'));
$pinjamanAmt = round((float) $request->pinjaman, 2);
// Online only for RM5k–50k; otherwise force cash path.
if ($caraTerima === 'ONLINE' && ($pinjamanAmt < 5000 || $pinjamanAmt > 50000)) {
// Online only within min/max pinjaman; otherwise force cash path.
if ($caraTerima === 'ONLINE' && ($pinjamanAmt < self::MIN_PINJAMAN || $pinjamanAmt > self::MAX_PINJAMAN)) {
$caraTerima = 'TUNAI';
}
resources/views/gadaian/v2/index.blade.php
+4 -3
View File
@@ -412,6 +412,8 @@
<script>
var api_url = "{{ api_url_for_browser() }}";
var kodcaw_ujrah = "<?php echo $cawangan_info['kodcaw'] ?>";
const MIN_PINJAMAN = {{ \App\Http\Controllers\GadaianController::MIN_PINJAMAN }};
const MAX_PINJAMAN = {{ \App\Http\Controllers\GadaianController::MAX_PINJAMAN }};
$('form input').keydown(function (e) {
if (e.keyCode == 13) {
e.preventDefault();
@@ -1302,8 +1304,7 @@
function toggleCaraTerima(pinjaman) {
var pembiayaanOnlineEnabled = $('#pembiayaan_online_enabled').val() === '1';
// MIN PINJAMAN = 1.00
if (pembiayaanOnlineEnabled && pinjaman >= 1 && pinjaman <= 50000) {
if (pembiayaanOnlineEnabled && pinjaman >= MIN_PINJAMAN && pinjaman <= MAX_PINJAMAN) {
$('#cara_terima_section').show();
toggleBankOnlineSection();
} else {
@@ -1416,7 +1417,7 @@
async function checkDisbursementFloat(pinjaman) {
var cara = $('input[name="cara_terima"]:checked').val() || 'TUNAI';
if (!(pinjaman >= 5000 && pinjaman <= 50000)) {
if (!(pinjaman >= MIN_PINJAMAN && pinjaman <= MAX_PINJAMAN)) {
cara = 'TUNAI';
}