From ff80f674d2d4d3c1d643992ca81b4a32bd05772e Mon Sep 17 00:00:00 2001
From: Afiq Hamzah <afiq.hamzah@pkb.net.my>
Date: Thu, 18 Jul 2024 14:46:22 +0800
Subject: [PATCH] Update codebase

- update env.example add important missing parameters
- add config for lelong api
- update InformationController to use lelong api config
---
 .env.example                                   | 14 ++++++++------
 app/Http/Controllers/InformationController.php |  7 ++-----
 config/api-lelong.php                          |  4 ++++
 3 files changed, 14 insertions(+), 11 deletions(-)
 create mode 100644 config/api-lelong.php

diff --git a/.env.example b/.env.example
index 44853cd..9ad5c0d 100644
--- a/.env.example
+++ b/.env.example
@@ -3,16 +3,18 @@ APP_ENV=local
 APP_KEY=
 APP_DEBUG=true
 APP_URL=http://localhost
+API_URL=http://localhost
+API_LELONG_URL=http://localhost
 
 LOG_CHANNEL=stack
 LOG_LEVEL=debug
 
-DB_CONNECTION=mysql
-DB_HOST=127.0.0.1
-DB_PORT=3306
-DB_DATABASE=laravel
-DB_USERNAME=root
-DB_PASSWORD=
+DB_CONNECTION_MYSQL=mysql
+DB_HOST_MYSQL=127.0.0.1
+DB_PORT_MYSQL=3306
+DB_DATABASE_MYSQL=laravel
+DB_USERNAME_MYSQL=root
+DB_PASSWORD_MYSQL=  
 
 BROADCAST_DRIVER=log
 CACHE_DRIVER=file
diff --git a/app/Http/Controllers/InformationController.php b/app/Http/Controllers/InformationController.php
index 9a23d3b..ce1d23c 100644
--- a/app/Http/Controllers/InformationController.php
+++ b/app/Http/Controllers/InformationController.php
@@ -41,8 +41,7 @@ class InformationController extends Controller
         if(isset($CustomerInfo['lelong'])){
             if(sizeof($CustomerInfo['lelong']) > 0){
                 foreach($CustomerInfo['lelong'] as $index=>$lelong){
-                    // $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get('https://adminbid.arrahn.com.my/api/portalApi',['norujukan' => $lelong['norujukan']])->json();
-                        $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get('https://niklah.arrahn.com.my/api/portalApi',['norujukan' => $lelong['norujukan']])->json();
+                        $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get(config('api-lelong.url') . '/api/portalApi',['norujukan' => $lelong['norujukan']])->json();
                     
                     if($array_lelong['lelong'] !== null){
                         $CustomerInfo['lelong'][$index] = collect($lelong)->merge($array_lelong['lelong'])->toArray();
@@ -89,8 +88,7 @@ class InformationController extends Controller
         if(isset($CustomerInfo['lelong'])){
             if(sizeof($CustomerInfo['lelong']) > 0){
                 foreach($CustomerInfo['lelong'] as $index=>$lel){
-                    $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get('https://niklah.arrahn.com.my/api/portalApi',['norujukan' => $lel['norujukan']])->json();
-                    // $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get('http://lelong.test/api/portalApi/',['norujukan' => $lel['norujukan']]);
+                    $array_lelong = Http::withOptions(['verify' => config('app.api_verify')])->get(config('api-lelong.url') . '/api/portalApi',['norujukan' => $lel['norujukan']])->json();
                     if($array_lelong['lelong'] !== null){
                         $CustomerInfo['lelong'][$index] = collect($lel)->merge($array_lelong['lelong'])->toArray();
                     }    
@@ -112,4 +110,3 @@ class InformationController extends Controller
         return view('auth.termasyarat', compact('termasyarat'));
     }
 }
-
diff --git a/config/api-lelong.php b/config/api-lelong.php
new file mode 100644
index 0000000..6114358
--- /dev/null
+++ b/config/api-lelong.php
@@ -0,0 +1,4 @@
+<?php
+return [
+  'url' => env('API_LELONG_URL', 'https://niklah.arrahn.com.my')
+];