From f7b4f919965ee78d92fa90fddd1f76a2330aef82 Mon Sep 17 00:00:00 2001
From: Afiq Hamzah <afiq.hamzah@pkb.net.my>
Date: Thu, 1 Aug 2024 14:54:02 +0800
Subject: [PATCH] Throw exception in catch block to ensure that the code
 execution / flowed stops

 - This to prevent broken data to be entered into tables
---
 app/Http/Controllers/TransactionOnlineController.php | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/app/Http/Controllers/TransactionOnlineController.php b/app/Http/Controllers/TransactionOnlineController.php
index 8229f80..10e9c9e 100644
--- a/app/Http/Controllers/TransactionOnlineController.php
+++ b/app/Http/Controllers/TransactionOnlineController.php
@@ -121,6 +121,7 @@ class TransactionOnlineController extends Controller
                 OnlineTransactionLoggerService::logsAfterDBTransaction($transaction->billplz_id, TransactionOnlineStatus::CRONJOB_REGISTER_GLDETAIL, $glDetail, $glDetailData);
             } catch (\Exception $e) {
                 OnlineTransactionLoggerService::logsAfterDBTransaction($transaction->billplz_id, TransactionOnlineStatus::CRONJOB_REGISTER_GLDETAIL, $glDetail, $e->getMessage());
+                throw $e;
             }
 
             $transactionOnlineData = [
@@ -133,6 +134,7 @@ class TransactionOnlineController extends Controller
                 OnlineTransactionLoggerService::logsAfterDBTransaction($transaction['billplz_id'], TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_ONLINE, $transactionOnlineData, $transactionOnline);
             } catch (\Exception $e) {
                 OnlineTransactionLoggerService::logsAfterDBTransaction($transaction['billplz_id'], TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_ONLINE, $transactionOnlineData, $e->getMessage());
+                throw $e;
             }
         }
 
@@ -368,6 +370,7 @@ class TransactionOnlineController extends Controller
                     OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSACTION, $data, $transaction);
                 } catch (\Exception $e) {
                     OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSACTION, $data, $e->getMessage());
+                    throw $e;
                 }
 
                 if ($gadai['tempoh'] >= 12.0) {
@@ -404,6 +407,7 @@ class TransactionOnlineController extends Controller
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_KEUNTUNGAN, $dataTransactionUpah, $transaction_upah);
                     } catch (\Exception $e) {
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_KEUNTUNGAN, $dataTransactionUpah, $e->getMessage());
+                        throw $e;
                     }
 
                 } else {
@@ -448,6 +452,7 @@ class TransactionOnlineController extends Controller
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_KEUNTUNGAN, $dataTransactionUpah, $transaction_upah);
                     } catch (\Exception $e) {
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_TRANSAKSI_KEUNTUNGAN, $dataTransactionUpah, $e->getMessage());
+                        throw $e;
                     }
                 }
 
@@ -471,6 +476,7 @@ class TransactionOnlineController extends Controller
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_GADAI, $updateGadaiData, $update_gadai);
                     } catch (\Exception $e) {
                         OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_UPDATE_GADAI, $updateGadaiData, $e->getMessage());
+                        throw $e;
                     }
 
                 });
@@ -493,6 +499,7 @@ class TransactionOnlineController extends Controller
                     OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_REGISTER_AUDIT, $auditData, $audit);
                 } catch (\Exception $e) {
                     OnlineTransactionLoggerService::logsAfterDBTransaction($bill_id, TransactionOnlineStatus::CRONJOB_REGISTER_AUDIT, $auditData, $e->getMessage());
+                    throw $e;
                 }
 
                 if (!$transaction || !$transaction_upah) {