From 55b41a4143347989d8fd6e8e3d0ebc1f7e8a4893 Mon Sep 17 00:00:00 2001 From: Afiq Hamzah Date: Sat, 17 May 2025 11:50:59 +0800 Subject: [PATCH] Fix errors when handling api errors --- .../BillplzTransactionSummaryController.php | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/app/Http/Controllers/BillplzTransactionSummaryController.php b/app/Http/Controllers/BillplzTransactionSummaryController.php index 0dc8b98..4122712 100644 --- a/app/Http/Controllers/BillplzTransactionSummaryController.php +++ b/app/Http/Controllers/BillplzTransactionSummaryController.php @@ -44,9 +44,16 @@ class BillplzTransactionSummaryController extends Controller $resolveBillplzPromise = function($promise){ try{ - $billplzBillsPromise = $promise->wait()->json(); + $waitedPromise = $promise->wait(); + + if($waitedPromise->failed()){ + throw new \Exception('Something went wrong with the API'); + } + + $billplzBillsPromise = $waitedPromise->json(); + }catch(\Exception $e){ - Log::error("ArrahnPay Portal API request failed for URL: {$$billplzBillsPromise->effectiveUri()->__toString()}", [ + Log::error("ArrahnPay Portal API request failed for URL: {$billplzBillsPromise->effectiveUri()->__toString()}", [ 'error' => $e->getMessage(), ]);